diff options
| author |   Wei Yongjun <yongjun_wei@trendmicro.com.cn> | 2012-09-10 12:41:15 +0800 |
|---|---|---|
| committer |   Wim Van Sebroeck <wim@iguana.be> | 2012-09-10 17:33:17 +0200 |
| commit | b232a70a1735c004f9ee6fdf363def527b9234b6 (patch) | |
| tree | 7c0ece61c982e452206d40fb2ffb8d22c22632ea /drivers/watchdog/watchdog_core.c | |
| parent | hpwdt: Fix kdump issue in hpwdt (diff) | |
| download | linux-dev-b232a70a1735c004f9ee6fdf363def527b9234b6.tar.xz linux-dev-b232a70a1735c004f9ee6fdf363def527b9234b6.zip | |
watchdog: move the dereference below the NULL test
The dereference should be moved below the NULL test.
spatch with a semantic match is used to found this.
(http://coccinelle.lip6.fr/)
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Wim Van Sebroeck <wim@iguana.be>
Diffstat (limited to 'drivers/watchdog/watchdog_core.c')
| -rw-r--r-- | drivers/watchdog/watchdog_core.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/watchdog/watchdog_core.c b/drivers/watchdog/watchdog_core.c index 6aa46a90ff02..3796434991fa 100644 --- a/drivers/watchdog/watchdog_core.c +++ b/drivers/watchdog/watchdog_core.c @@ -128,11 +128,12 @@ EXPORT_SYMBOL_GPL(watchdog_register_device); void watchdog_unregister_device(struct watchdog_device *wdd) { int ret; - int devno = wdd->cdev.dev; + int devno; if (wdd == NULL) return; + devno = wdd->cdev.dev; ret = watchdog_dev_unregister(wdd); if (ret) pr_err("error unregistering /dev/watchdog (err=%d)\n", ret); |