diff options
| author |   Jan Beulich <jbeulich@suse.com> | 2021-09-17 12:50:38 +0200 |
|---|---|---|
| committer |   Juergen Gross <jgross@suse.com> | 2021-09-20 17:01:21 +0200 |
| commit | 794d5b8a497ff053f56856472e2fae038fa761aa (patch) | |
| tree | d3f8197f07e19b666414abba45ec055898fbe042 /drivers/xen | |
| parent | xen/pci-swiotlb: reduce visibility of symbols (diff) | |
| download | linux-dev-794d5b8a497ff053f56856472e2fae038fa761aa.tar.xz linux-dev-794d5b8a497ff053f56856472e2fae038fa761aa.zip | |
swiotlb-xen: this is PV-only on x86
The code is unreachable for HVM or PVH, and it also makes little sense
in auto-translated environments. On Arm, with
xen_{create,destroy}_contiguous_region() both being stubs, I have a hard
time seeing what good the Xen specific variant does - the generic one
ought to be fine for all purposes there. Still Arm code explicitly
references symbols here, so the code will continue to be included there.
Instead of making PCI_XEN's "select" conditional, simply drop it -
SWIOTLB_XEN will be available unconditionally in the PV case anyway, and
is - as explained above - dead code in non-PV environments.
This in turn allows dropping the stubs for
xen_{create,destroy}_contiguous_region(), the former of which was broken
anyway - it failed to set the DMA handle output.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
Link: https://lore.kernel.org/r/5947b8ae-fdc7-225c-4838-84712265fc1e@suse.com
Signed-off-by: Juergen Gross <jgross@suse.com>
Diffstat (limited to 'drivers/xen')
| -rw-r--r-- | drivers/xen/Kconfig | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig index a37eb52fb401..22f5aff0c136 100644 --- a/drivers/xen/Kconfig +++ b/drivers/xen/Kconfig @@ -177,6 +177,7 @@ config XEN_GRANT_DMA_ALLOC config SWIOTLB_XEN def_bool y + depends on XEN_PV || ARM || ARM64 select DMA_OPS select SWIOTLB |