diff options
| author |   Andy Shevchenko <andriy.shevchenko@linux.intel.com> | 2017-10-18 17:40:16 +0200 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2017-10-20 13:11:04 +0100 |
| commit | 025d0dfcc1dd90e2489ab9c500c8f5efbe3ce82f (patch) | |
| tree | cb4373e659700399a188fc9d6ffb1c3fc0feec17 /drivers | |
| parent | s390/qeth: remove duplicated device matching (diff) | |
| download | linux-dev-025d0dfcc1dd90e2489ab9c500c8f5efbe3ce82f.tar.xz linux-dev-025d0dfcc1dd90e2489ab9c500c8f5efbe3ce82f.zip | |
s390/qeth: use kstrtobool() in qeth_bridgeport_hostnotification_store()
The sysfs enabled value is a boolean, so kstrtobool() is a better fit
for parsing the input string since it does the range checking for us.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Julian Wiedmann <jwi@linux.vnet.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/s390/net/qeth_l2_sys.c | 13 |
1 files changed, 5 insertions, 8 deletions
diff --git a/drivers/s390/net/qeth_l2_sys.c b/drivers/s390/net/qeth_l2_sys.c index 4608daedb204..470a4e5f3c62 100644 --- a/drivers/s390/net/qeth_l2_sys.c +++ b/drivers/s390/net/qeth_l2_sys.c @@ -146,18 +146,15 @@ static ssize_t qeth_bridgeport_hostnotification_store(struct device *dev, struct device_attribute *attr, const char *buf, size_t count) { struct qeth_card *card = dev_get_drvdata(dev); - int rc = 0; - int enable; + bool enable; + int rc; if (!card) return -EINVAL; - if (sysfs_streq(buf, "0")) - enable = 0; - else if (sysfs_streq(buf, "1")) - enable = 1; - else - return -EINVAL; + rc = kstrtobool(buf, &enable); + if (rc) + return rc; mutex_lock(&card->conf_mutex); |