diff options
| author |   Kangjie Lu <kjlu@umn.edu> | 2019-03-11 01:05:41 -0500 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2019-03-11 13:34:31 -0700 |
| commit | 0b31d98d90f09868dce71319615e19cd1f146fb6 (patch) | |
| tree | a2c42351e94fb41fb0e8268c42ed35169971de69 /drivers | |
| parent | net: lio_core: fix two NULL pointer dereferences (diff) | |
| download | linux-dev-0b31d98d90f09868dce71319615e19cd1f146fb6.tar.xz linux-dev-0b31d98d90f09868dce71319615e19cd1f146fb6.zip | |
net: thunder: fix a potential NULL pointer dereference
In case alloc_ordered_workqueue fails, the fix reports the error
and returns -ENOMEM.
Signed-off-by: Kangjie Lu <kjlu@umn.edu>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/net/ethernet/cavium/thunder/nicvf_main.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/drivers/net/ethernet/cavium/thunder/nicvf_main.c b/drivers/net/ethernet/cavium/thunder/nicvf_main.c index 503cfadff4ac..aa2be4807191 100644 --- a/drivers/net/ethernet/cavium/thunder/nicvf_main.c +++ b/drivers/net/ethernet/cavium/thunder/nicvf_main.c @@ -2234,6 +2234,12 @@ static int nicvf_probe(struct pci_dev *pdev, const struct pci_device_id *ent) nic->nicvf_rx_mode_wq = alloc_ordered_workqueue("nicvf_rx_mode_wq_VF%d", WQ_MEM_RECLAIM, nic->vf_id); + if (!nic->nicvf_rx_mode_wq) { + err = -ENOMEM; + dev_err(dev, "Failed to allocate work queue\n"); + goto err_unregister_interrupts; + } + INIT_WORK(&nic->rx_mode_work.work, nicvf_set_rx_mode_task); spin_lock_init(&nic->rx_mode_wq_lock); mutex_init(&nic->rx_mode_mtx); |