diff options
| author |   David S. Miller <davem@davemloft.net> | 2009-02-07 02:20:25 -0800 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2009-02-07 02:20:25 -0800 |
| commit | 0b492fce3d72d982a7981905f85484a1e1ba7fde (patch) | |
| tree | df2530cbcda3522278f78fe51440dd3a58bda07c /drivers | |
| parent | 9p: fix endian issues [attempt 3] (diff) | |
| download | linux-dev-0b492fce3d72d982a7981905f85484a1e1ba7fde.tar.xz linux-dev-0b492fce3d72d982a7981905f85484a1e1ba7fde.zip | |
sunhme: Don't match PCI devices in SBUS probe.
Unfortunately, the OF device tree nodes for SBUS and PCI
hme devices have the same device node name on some systems.
So if the name of the parent node isn't 'sbus', skip it.
Based upon an excellent report and detective work by
Meelis Roos and Eric Brower.
Signed-off-by: David S. Miller <davem@davemloft.net>
Tested-by: Meelis Roos <mroos@linux.ee>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/net/sunhme.c | 12 |
1 files changed, 8 insertions, 4 deletions
diff --git a/drivers/net/sunhme.c b/drivers/net/sunhme.c index 7a72a3112f0a..cc4013be5e18 100644 --- a/drivers/net/sunhme.c +++ b/drivers/net/sunhme.c @@ -2629,6 +2629,14 @@ static int __devinit happy_meal_sbus_probe_one(struct of_device *op, int is_qfe) int i, qfe_slot = -1; int err = -ENODEV; + sbus_dp = to_of_device(op->dev.parent)->node; + if (is_qfe) + sbus_dp = to_of_device(op->dev.parent->parent)->node; + + /* We can match PCI devices too, do not accept those here. */ + if (strcmp(sbus_dp->name, "sbus")) + return err; + if (is_qfe) { qp = quattro_sbus_find(op); if (qp == NULL) @@ -2734,10 +2742,6 @@ static int __devinit happy_meal_sbus_probe_one(struct of_device *op, int is_qfe) if (qp != NULL) hp->happy_flags |= HFLAG_QUATTRO; - sbus_dp = to_of_device(op->dev.parent)->node; - if (is_qfe) - sbus_dp = to_of_device(op->dev.parent->parent)->node; - /* Get the supported DVMA burst sizes from our Happy SBUS. */ hp->happy_bursts = of_getintprop_default(sbus_dp, "burst-sizes", 0x00); |