diff options
| author |   Peter Griffin <peter.griffin@linaro.org> | 2014-08-15 13:40:10 +0100 |
|---|---|---|
| committer |   Kishon Vijay Abraham I <kishon@ti.com> | 2014-09-24 15:18:32 +0530 |
| commit | 0b68253d9f8d25728bd2b7ec378bfb5e116cbe17 (patch) | |
| tree | a4abb733ae132cc9f282d767e28abd1d15115040 /drivers | |
| parent | phy: phy-mvebu-sata: Add missing error check for devm_kzalloc (diff) | |
| download | linux-dev-0b68253d9f8d25728bd2b7ec378bfb5e116cbe17.tar.xz linux-dev-0b68253d9f8d25728bd2b7ec378bfb5e116cbe17.zip | |
phy: phy-omap-usb2: Remove unncessary site specific OOM messages
The site specific OOM messages are unncessary, because they duplicate
messages from the memory subsystem which include dump_stack().
Removing these superflous messages makes the kernel smaller. A discussion
here http://patchwork.ozlabs.org/patch/324158/ found that all error paths
from kzalloc will print a error message, and that any error path which maybe
found which doesn't would be considered a bug in kzalloc.
Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/phy/phy-omap-usb2.c | 8 |
1 files changed, 2 insertions, 6 deletions
diff --git a/drivers/phy/phy-omap-usb2.c b/drivers/phy/phy-omap-usb2.c index 93d78359246c..51c6f92220c5 100644 --- a/drivers/phy/phy-omap-usb2.c +++ b/drivers/phy/phy-omap-usb2.c @@ -212,16 +212,12 @@ static int omap_usb2_probe(struct platform_device *pdev) phy_data = (struct usb_phy_data *)of_id->data; phy = devm_kzalloc(&pdev->dev, sizeof(*phy), GFP_KERNEL); - if (!phy) { - dev_err(&pdev->dev, "unable to allocate memory for USB2 PHY\n"); + if (!phy) return -ENOMEM; - } otg = devm_kzalloc(&pdev->dev, sizeof(*otg), GFP_KERNEL); - if (!otg) { - dev_err(&pdev->dev, "unable to allocate memory for USB OTG\n"); + if (!otg) return -ENOMEM; - } phy->dev = &pdev->dev; |