diff options
| author |   Stephen Hemminger <stephen@networkplumber.org> | 2018-03-20 15:03:04 -0700 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2018-03-22 12:45:09 -0400 |
| commit | 0ef58b0a05c127762f975c3dfe8b922e4aa87a29 (patch) | |
| tree | 2a4f98ccc66796cca6e6467d6889f3c33424711b /drivers | |
| parent | hv_netvsc: use RCU to fix concurrent rx and queue changes (diff) | |
| download | linux-dev-0ef58b0a05c127762f975c3dfe8b922e4aa87a29.tar.xz linux-dev-0ef58b0a05c127762f975c3dfe8b922e4aa87a29.zip | |
hv_netvsc: change GPAD teardown order on older versions
On older versions of Windows, the host ignores messages after
vmbus channel is closed.
Workaround this by doing what Windows does and send the teardown
before close on older versions of NVSP protocol.
Reported-by: Mohammed Gamal <mgamal@redhat.com>
Fixes: 0cf737808ae7 ("hv_netvsc: netvsc_teardown_gpadl() split")
Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/net/hyperv/netvsc.c | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/drivers/net/hyperv/netvsc.c b/drivers/net/hyperv/netvsc.c index 12c044baf1af..37b0a30d6b03 100644 --- a/drivers/net/hyperv/netvsc.c +++ b/drivers/net/hyperv/netvsc.c @@ -571,10 +571,15 @@ void netvsc_device_remove(struct hv_device *device) */ netdev_dbg(ndev, "net device safe to remove\n"); + /* older versions require that buffer be revoked before close */ + if (net_device->nvsp_version < NVSP_PROTOCOL_VERSION_4) + netvsc_teardown_gpadl(device, net_device); + /* Now, we can close the channel safely */ vmbus_close(device->channel); - netvsc_teardown_gpadl(device, net_device); + if (net_device->nvsp_version >= NVSP_PROTOCOL_VERSION_4) + netvsc_teardown_gpadl(device, net_device); /* Release all resources */ free_netvsc_device_rcu(net_device); |