diff options
| author |   Leon Romanovsky <leonro@mellanox.com> | 2017-01-18 14:10:31 +0200 |
|---|---|---|
| committer |   Doug Ledford <dledford@redhat.com> | 2017-02-14 10:14:25 -0500 |
| commit | 12bbf1ea7e3b35892dbb8636b978160bc9576b61 (patch) | |
| tree | 087f0cc6decad1e76204a8b0dbd4d7ed82342c08 /drivers | |
| parent | IB/mlx5: Fix out-of-bound access (diff) | |
| download | linux-dev-12bbf1ea7e3b35892dbb8636b978160bc9576b61.tar.xz linux-dev-12bbf1ea7e3b35892dbb8636b978160bc9576b61.zip | |
IB/mlx5: Return error for unsupported signature type
In case of unsupported singature, we returned positive
value, while the better approach is to return -EINVAL.
In addition, in this change, the error print is enriched
to provide an actual supplied signature type.
Fixes: e6631814fb3a ("IB/mlx5: Support IB_WR_REG_SIG_MR")
Cc: Sagi Grimberg <sagi@grimberg.me>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
Signed-off-by: Leon Romanovsky <leon@kernel.org>
Signed-off-by: Doug Ledford <dledford@redhat.com>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/infiniband/hw/mlx5/qp.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/infiniband/hw/mlx5/qp.c b/drivers/infiniband/hw/mlx5/qp.c index 6a83fb32599d..90210745366a 100644 --- a/drivers/infiniband/hw/mlx5/qp.c +++ b/drivers/infiniband/hw/mlx5/qp.c @@ -3637,8 +3637,9 @@ static int set_psv_wr(struct ib_sig_domain *domain, psv_seg->ref_tag = cpu_to_be32(domain->sig.dif.ref_tag); break; default: - pr_err("Bad signature type given.\n"); - return 1; + pr_err("Bad signature type (%d) is given.\n", + domain->sig_type); + return -EINVAL; } *seg += sizeof(*psv_seg); |