diff options
| author |   Antoine Tenart <atenart@kernel.org> | 2022-11-08 16:34:58 +0100 |
|---|---|---|
| committer |   Paolo Abeni <pabeni@redhat.com> | 2022-11-10 11:58:52 +0100 |
| commit | 1b16b3fdf675cca15a537572bac50cc5354368fc (patch) | |
| tree | 41cfb09c50af1eb45cdd23f81403a70a2bd2df50 /drivers | |
| parent | Merge branch 'stmmac-dwmac-loongson-fixes-three-leaks' (diff) | |
| download | linux-dev-1b16b3fdf675cca15a537572bac50cc5354368fc.tar.xz linux-dev-1b16b3fdf675cca15a537572bac50cc5354368fc.zip | |
net: phy: mscc: macsec: clear encryption keys when freeing a flow
Commit aaab73f8fba4 ("macsec: clear encryption keys from the stack after
setting up offload") made sure to clean encryption keys from the stack
after setting up offloading, but the MSCC PHY driver made a copy, kept
it in the flow data and did not clear it when freeing a flow. Fix this.
Fixes: 28c5107aa904 ("net: phy: mscc: macsec support")
Signed-off-by: Antoine Tenart <atenart@kernel.org>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/net/phy/mscc/mscc_macsec.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/net/phy/mscc/mscc_macsec.c b/drivers/net/phy/mscc/mscc_macsec.c index ee5b17edca39..f81b077618f4 100644 --- a/drivers/net/phy/mscc/mscc_macsec.c +++ b/drivers/net/phy/mscc/mscc_macsec.c @@ -632,6 +632,7 @@ static void vsc8584_macsec_free_flow(struct vsc8531_private *priv, list_del(&flow->list); clear_bit(flow->index, bitmap); + memzero_explicit(flow->key, sizeof(flow->key)); kfree(flow); } |