diff options
| author |   Dan Carpenter <dan.carpenter@oracle.com> | 2022-07-12 17:42:25 +0300 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2022-07-13 14:21:42 +0100 |
| commit | 23aa6d5088e3bd65de77c5c307237b9937f8b48a (patch) | |
| tree | 8c829d8e484030b8471fb1573f8eddba3d453fad /drivers | |
| parent | net: ftgmac100: Hold reference returned by of_get_child_by_name() (diff) | |
| download | linux-dev-23aa6d5088e3bd65de77c5c307237b9937f8b48a.tar.xz linux-dev-23aa6d5088e3bd65de77c5c307237b9937f8b48a.zip | |
net: stmmac: fix leaks in probe
These two error paths should clean up before returning.
Fixes: 2bb4b98b60d7 ("net: stmmac: Add Ingenic SoCs MAC support.")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/net/ethernet/stmicro/stmmac/dwmac-ingenic.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-ingenic.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-ingenic.c index 9a6d819b84ae..378b4dd826bb 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-ingenic.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-ingenic.c @@ -273,7 +273,8 @@ static int ingenic_mac_probe(struct platform_device *pdev) mac->tx_delay = tx_delay_ps * 1000; } else { dev_err(&pdev->dev, "Invalid TX clock delay: %dps\n", tx_delay_ps); - return -EINVAL; + ret = -EINVAL; + goto err_remove_config_dt; } } @@ -283,7 +284,8 @@ static int ingenic_mac_probe(struct platform_device *pdev) mac->rx_delay = rx_delay_ps * 1000; } else { dev_err(&pdev->dev, "Invalid RX clock delay: %dps\n", rx_delay_ps); - return -EINVAL; + ret = -EINVAL; + goto err_remove_config_dt; } } |