diff options
| author |   Johan Hovold <johan@kernel.org> | 2019-10-09 19:09:44 +0200 |
|---|---|---|
| committer |   Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2019-10-10 12:41:19 +0200 |
| commit | 369dca424a3f9ef80bc4e5a5ccdd41a17ce306c1 (patch) | |
| tree | 845fe2bd67dffde52c350e6fe81c43520cf193a6 /drivers | |
| parent | USB: usb-skeleton: fix use-after-free after driver unbind (diff) | |
| download | linux-dev-369dca424a3f9ef80bc4e5a5ccdd41a17ce306c1.tar.xz linux-dev-369dca424a3f9ef80bc4e5a5ccdd41a17ce306c1.zip | |
USB: usb-skeleton: drop redundant in-urb check
The driver bails out at probe if we can't find a bulk-in endpoint or
if we fail to allocate the URB, so drop the check in read().
Signed-off-by: Johan Hovold <johan@kernel.org>
Link: https://lore.kernel.org/r/20191009170944.30057-4-johan@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/usb/usb-skeleton.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/usb/usb-skeleton.c b/drivers/usb/usb-skeleton.c index be311787403e..2dc58766273a 100644 --- a/drivers/usb/usb-skeleton.c +++ b/drivers/usb/usb-skeleton.c @@ -230,8 +230,7 @@ static ssize_t skel_read(struct file *file, char *buffer, size_t count, dev = file->private_data; - /* if we cannot read at all, return EOF */ - if (!dev->bulk_in_urb || !count) + if (!count) return 0; /* no concurrent readers */ |