diff options
| author |   Ido Schimmel <idosch@mellanox.com> | 2020-02-07 19:26:28 +0200 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2020-02-07 18:47:01 +0100 |
| commit | 3a99cbb6fa7bca1995586ec2dc21b0368aad4937 (patch) | |
| tree | 5306ed544549ffceef862deb5bd0d94e9dc82720 /drivers | |
| parent | mlxsw: core: Add validation of hardware device types for MGPIR register (diff) | |
| download | linux-dev-3a99cbb6fa7bca1995586ec2dc21b0368aad4937.tar.xz linux-dev-3a99cbb6fa7bca1995586ec2dc21b0368aad4937.zip | |
mlxsw: spectrum_dpipe: Add missing error path
In case devlink_dpipe_entry_ctx_prepare() failed, release RTNL that was
previously taken and free the memory allocated by
mlxsw_sp_erif_entry_prepare().
Fixes: 2ba5999f009d ("mlxsw: spectrum: Add Support for erif table entries access")
Signed-off-by: Ido Schimmel <idosch@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/net/ethernet/mellanox/mlxsw/spectrum_dpipe.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_dpipe.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_dpipe.c index 49933818c6f5..2dc0978428e6 100644 --- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_dpipe.c +++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_dpipe.c @@ -215,7 +215,7 @@ mlxsw_sp_dpipe_table_erif_entries_dump(void *priv, bool counters_enabled, start_again: err = devlink_dpipe_entry_ctx_prepare(dump_ctx); if (err) - return err; + goto err_ctx_prepare; j = 0; for (; i < rif_count; i++) { struct mlxsw_sp_rif *rif = mlxsw_sp_rif_by_index(mlxsw_sp, i); @@ -247,6 +247,7 @@ start_again: return 0; err_entry_append: err_entry_get: +err_ctx_prepare: rtnl_unlock(); devlink_dpipe_entry_clear(&entry); return err; |