diff options
| author |   Eric Farman <farman@linux.ibm.com> | 2019-05-15 01:42:43 +0200 |
|---|---|---|
| committer |   Cornelia Huck <cohuck@redhat.com> | 2019-06-03 12:02:55 +0200 |
| commit | 4e31d6aecfbbe63cf09b8fe48572d20d2062c406 (patch) | |
| tree | b94b89dd94a3baf03007a75e187bd0cd17573a41 /drivers | |
| parent | s390/cio: Update SCSW if it points to the end of the chain (diff) | |
| download | linux-dev-4e31d6aecfbbe63cf09b8fe48572d20d2062c406.tar.xz linux-dev-4e31d6aecfbbe63cf09b8fe48572d20d2062c406.zip | |
s390/cio: Set vfio-ccw FSM state before ioeventfd
Otherwise, the guest can believe it's okay to start another I/O
and bump into the non-idle state. This results in a cc=2 (with
the asynchronous CSCH/HSCH code) returned to the guest, which is
unfortunate since everything is otherwise working normally.
Signed-off-by: Eric Farman <farman@linux.ibm.com>
Reviewed-by: Pierre Morel <pmorel@linux.ibm.com>
Message-Id: <20190514234248.36203-3-farman@linux.ibm.com>
Reviewed-by: Farhan Ali <alifm@linux.ibm.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/s390/cio/vfio_ccw_drv.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/s390/cio/vfio_ccw_drv.c b/drivers/s390/cio/vfio_ccw_drv.c index ee8767f5845a..66a66ac1f3d1 100644 --- a/drivers/s390/cio/vfio_ccw_drv.c +++ b/drivers/s390/cio/vfio_ccw_drv.c @@ -95,11 +95,11 @@ static void vfio_ccw_sch_io_todo(struct work_struct *work) memcpy(private->io_region->irb_area, irb, sizeof(*irb)); mutex_unlock(&private->io_mutex); - if (private->io_trigger) - eventfd_signal(private->io_trigger, 1); - if (private->mdev && is_final) private->state = VFIO_CCW_STATE_IDLE; + + if (private->io_trigger) + eventfd_signal(private->io_trigger, 1); } /* |