diff options
| author |   Michael Chan <mchan@broadcom.com> | 2008-05-02 16:56:44 -0700 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2008-05-02 16:56:44 -0700 |
| commit | 543a827d7a5600a71855bd6afacac78536c86822 (patch) | |
| tree | 74a308cd8a4d7d4dbdba8b60e0230cfeddb69032 /drivers | |
| parent | bnx2: Refine remote PHY locking. (diff) | |
| download | linux-dev-543a827d7a5600a71855bd6afacac78536c86822.tar.xz linux-dev-543a827d7a5600a71855bd6afacac78536c86822.zip | |
bnx2: Fix remote PHY initial link state.
On some remote PHY blade systems, the driver receives no initial link
interrupt. As a result, the GMII/MII MAC mode does not get setup properly.
To fix this problem, we add an initial poll of the link state after chip
reset.
With this change, the setting of the initial carrier state in the init
code can be eliminated.
Signed-off-by: Michael Chan <mchan@broadcom.com>
Signed-off-by: Benjamin Li <benli@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/net/bnx2.c | 9 |
1 files changed, 2 insertions, 7 deletions
diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c index 506c5ccd7156..d681f3153e7c 100644 --- a/drivers/net/bnx2.c +++ b/drivers/net/bnx2.c @@ -4216,13 +4216,6 @@ bnx2_init_remote_phy(struct bnx2 *bp) if (netif_running(bp->dev)) { u32 sig; - if (val & BNX2_LINK_STATUS_LINK_UP) { - bp->link_up = 1; - netif_carrier_on(bp->dev); - } else { - bp->link_up = 0; - netif_carrier_off(bp->dev); - } sig = BNX2_DRV_ACK_CAP_SIGNATURE | BNX2_FW_CAP_REMOTE_PHY_CAPABLE; bnx2_shmem_wr(bp, BNX2_DRV_ACK_CAP_MB, sig); @@ -4879,6 +4872,8 @@ bnx2_init_nic(struct bnx2 *bp) spin_lock_bh(&bp->phy_lock); bnx2_init_phy(bp); bnx2_set_link(bp); + if (bp->phy_flags & BNX2_PHY_FLAG_REMOTE_PHY_CAP) + bnx2_remote_phy_event(bp); spin_unlock_bh(&bp->phy_lock); return 0; } |