diff options
| author |   YueHaibing <yuehaibing@huawei.com> | 2019-10-23 21:59:41 +0800 |
|---|---|---|
| committer |   Joerg Roedel <jroedel@suse.de> | 2019-10-30 10:16:37 +0100 |
| commit | 565d454280f85c0a4f204fb160f3d90f8418c080 (patch) | |
| tree | 08795ffe33ad644abfe0ea648f821fabc59b3eb2 /drivers | |
| parent | Linux 5.4-rc5 (diff) | |
| download | linux-dev-565d454280f85c0a4f204fb160f3d90f8418c080.tar.xz linux-dev-565d454280f85c0a4f204fb160f3d90f8418c080.zip | |
iommu/ipmmu-vmsa: Remove dev_err() on platform_get_irq() failure
platform_get_irq() will call dev_err() itself on failure,
so there is no need for the driver to also do this.
This is detected by coccinelle.
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Joerg Roedel <jroedel@suse.de>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/iommu/ipmmu-vmsa.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/iommu/ipmmu-vmsa.c b/drivers/iommu/ipmmu-vmsa.c index 237103465b82..2639fc718117 100644 --- a/drivers/iommu/ipmmu-vmsa.c +++ b/drivers/iommu/ipmmu-vmsa.c @@ -1105,10 +1105,8 @@ static int ipmmu_probe(struct platform_device *pdev) /* Root devices have mandatory IRQs */ if (ipmmu_is_root(mmu)) { irq = platform_get_irq(pdev, 0); - if (irq < 0) { - dev_err(&pdev->dev, "no IRQ found\n"); + if (irq < 0) return irq; - } ret = devm_request_irq(&pdev->dev, irq, ipmmu_irq, 0, dev_name(&pdev->dev), mmu); |