diff options
| author |   Igor Russkikh <Igor.Russkikh@aquantia.com> | 2019-08-30 12:08:36 +0000 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2019-08-31 19:07:11 -0700 |
| commit | 5c47e3ba6fe52465603cf9d816b3371e6881d649 (patch) | |
| tree | 3e44969787c51266a3a6450060b8d108488dd76a /drivers | |
| parent | net: aquantia: reapply vlan filters on up (diff) | |
| download | linux-dev-5c47e3ba6fe52465603cf9d816b3371e6881d649.tar.xz linux-dev-5c47e3ba6fe52465603cf9d816b3371e6881d649.zip | |
net: aquantia: linkstate irq should be oneshot
Declaring threaded irq handler should also indicate the irq is
oneshot. It is oneshot indeed, because HW implements irq automasking
on trigger.
Not declaring this causes some kernel configurations to fail
on interface up, because request_threaded_irq returned an err code.
The issue was originally hidden on normal x86_64 configuration with
latest kernel, because depending on interrupt controller, irq driver
added ONESHOT flag on its own.
Issue was observed on older kernels (4.14) where no such logic exists.
Fixes: 4c83f170b3ac ("net: aquantia: link status irq handling")
Signed-off-by: Igor Russkikh <igor.russkikh@aquantia.com>
Reported-by: Michael Symolkin <Michael.Symolkin@aquantia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/net/ethernet/aquantia/atlantic/aq_nic.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_nic.c b/drivers/net/ethernet/aquantia/atlantic/aq_nic.c index e1392766e21e..8f66e7817811 100644 --- a/drivers/net/ethernet/aquantia/atlantic/aq_nic.c +++ b/drivers/net/ethernet/aquantia/atlantic/aq_nic.c @@ -393,7 +393,7 @@ int aq_nic_start(struct aq_nic_s *self) self->aq_nic_cfg.link_irq_vec); err = request_threaded_irq(irqvec, NULL, aq_linkstate_threaded_isr, - IRQF_SHARED, + IRQF_SHARED | IRQF_ONESHOT, self->ndev->name, self); if (err < 0) goto err_exit; |