diff options
| author |   Eric Dumazet <edumazet@google.com> | 2017-04-19 09:59:25 -0700 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2017-04-21 13:24:06 -0400 |
| commit | 6bc6895bdd6744e0136eaa4a11fbdb20a7db4e40 (patch) | |
| tree | b110925dec762d275560dc72e189a8129d536159 /drivers | |
| parent | lan78xx: use skb_cow_head() to deal with cloned skbs (diff) | |
| download | linux-dev-6bc6895bdd6744e0136eaa4a11fbdb20a7db4e40.tar.xz linux-dev-6bc6895bdd6744e0136eaa4a11fbdb20a7db4e40.zip | |
ch9200: use skb_cow_head() to deal with cloned skbs
We need to ensure there is enough headroom to push extra header,
but we also need to check if we are allowed to change headers.
skb_cow_head() is the proper helper to deal with this.
Fixes: 4a476bd6d1d9 ("usbnet: New driver for QinHeng CH9200 devices")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: James Hughes <james.hughes@raspberrypi.org>
Cc: Matthew Garrett <mjg59@srcf.ucam.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/net/usb/ch9200.c | 9 |
1 files changed, 2 insertions, 7 deletions
diff --git a/drivers/net/usb/ch9200.c b/drivers/net/usb/ch9200.c index 8a40202c0a17..c4f1c363e24b 100644 --- a/drivers/net/usb/ch9200.c +++ b/drivers/net/usb/ch9200.c @@ -254,14 +254,9 @@ static struct sk_buff *ch9200_tx_fixup(struct usbnet *dev, struct sk_buff *skb, tx_overhead = 0x40; len = skb->len; - if (skb_headroom(skb) < tx_overhead) { - struct sk_buff *skb2; - - skb2 = skb_copy_expand(skb, tx_overhead, 0, flags); + if (skb_cow_head(skb, tx_overhead)) { dev_kfree_skb_any(skb); - skb = skb2; - if (!skb) - return NULL; + return NULL; } __skb_push(skb, tx_overhead); |