diff options
| author |   Jarod Wilson <jarod@redhat.com> | 2019-06-07 10:59:26 -0400 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2019-06-09 13:36:01 -0700 |
| commit | 75466dce4d72a12cff3785bcd5d589c17224c5e4 (patch) | |
| tree | a4c7b4afe03f4f8d0465958c8eb2b9ab31920d64 /drivers | |
| parent | net: fec_main: Use dev_err() instead of pr_err() (diff) | |
| download | linux-dev-75466dce4d72a12cff3785bcd5d589c17224c5e4.tar.xz linux-dev-75466dce4d72a12cff3785bcd5d589c17224c5e4.zip | |
bonding: improve event debug usability
Seeing bonding debug log data along the lines of "event: 5" is a bit spartan,
and often requires a lookup table if you don't remember what every event is.
Make use of netdev_cmd_to_name for an improved debugging experience, so for
the prior example, you'll see: "bond_netdev_event received NETDEV_REGISTER"
instead (both are prefixed with the device for which the event pertains).
CC: Jay Vosburgh <j.vosburgh@gmail.com>
CC: Veaceslav Falico <vfalico@gmail.com>
CC: Andy Gospodarek <andy@greyhouse.net>
CC: netdev@vger.kernel.org
Signed-off-by: Jarod Wilson <jarod@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/net/bonding/bond_main.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c index ad53e5f72990..d575e94a07bf 100644 --- a/drivers/net/bonding/bond_main.c +++ b/drivers/net/bonding/bond_main.c @@ -3223,7 +3223,8 @@ static int bond_netdev_event(struct notifier_block *this, { struct net_device *event_dev = netdev_notifier_info_to_dev(ptr); - netdev_dbg(event_dev, "event: %lx\n", event); + netdev_dbg(event_dev, "%s received %s\n", + __func__, netdev_cmd_to_name(event)); if (!(event_dev->priv_flags & IFF_BONDING)) return NOTIFY_DONE; |