diff options
| author |   Mike Snitzer <snitzer@redhat.com> | 2017-11-16 10:22:42 -0500 |
|---|---|---|
| committer | Mike Snitzer <snitzer@redhat.com> | 2017-11-16 16:33:54 -0500 |
| commit | 7dea378b23fdc5003379615fc579dbf987ed8128 (patch) | |
| tree | 30b4da041c670ce537d0b84dcb7f43fe91f571bd /drivers | |
| parent | dm: discard support requires all targets in a table support discards (diff) | |
| download | linux-dev-7dea378b23fdc5003379615fc579dbf987ed8128.tar.xz linux-dev-7dea378b23fdc5003379615fc579dbf987ed8128.zip | |
dm: do not set 'discards_supported' in targets that do not need it
The DM target's 'discards_supported' flag is intended to act as an
override. Meaning, even if the underlying storage doesn't support
discards the DM target will.
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/md/dm-era-target.c | 1 | ||||
| -rw-r--r-- | drivers/md/dm-raid.c | 6 |
2 files changed, 0 insertions, 7 deletions
diff --git a/drivers/md/dm-era-target.c b/drivers/md/dm-era-target.c index ba84b8d62cd0..73a5c198113a 100644 --- a/drivers/md/dm-era-target.c +++ b/drivers/md/dm-era-target.c @@ -1513,7 +1513,6 @@ static int era_ctr(struct dm_target *ti, unsigned argc, char **argv) ti->flush_supported = true; ti->num_discard_bios = 1; - ti->discards_supported = true; era->callbacks.congested_fn = era_is_congested; dm_table_add_target_callbacks(ti->table, &era->callbacks); diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c index a25eebd98996..ea6eb96b5012 100644 --- a/drivers/md/dm-raid.c +++ b/drivers/md/dm-raid.c @@ -2887,9 +2887,6 @@ static void configure_discard_support(struct raid_set *rs) bool raid456; struct dm_target *ti = rs->ti; - /* Assume discards not supported until after checks below. */ - ti->discards_supported = false; - /* * XXX: RAID level 4,5,6 require zeroing for safety. */ @@ -2914,9 +2911,6 @@ static void configure_discard_support(struct raid_set *rs) } } - /* All RAID members properly support discards */ - ti->discards_supported = true; - /* * RAID1 and RAID10 personalities require bio splitting, * RAID0/4/5/6 don't and process large discard bios properly. |