diff options
| author |   Dan Carpenter <dan.carpenter@oracle.com> | 2017-05-08 15:55:17 -0700 |
|---|---|---|
| committer |   Linus Torvalds <torvalds@linux-foundation.org> | 2017-05-08 17:15:10 -0700 |
| commit | 8128a31eaadbcdfa37774bbd28f3f00bac69996a (patch) | |
| tree | 6f1eca48357ea139566573e5bfbff090e7756c83 /drivers | |
| parent | drivers/misc/vmw_vmci/vmci_queue_pair.c: fix a couple integer overflow tests (diff) | |
| download | linux-dev-8128a31eaadbcdfa37774bbd28f3f00bac69996a.tar.xz linux-dev-8128a31eaadbcdfa37774bbd28f3f00bac69996a.zip | |
drivers/misc/c2port/c2port-duramar2150.c: checking for NULL instead of IS_ERR()
c2port_device_register() never returns NULL, it uses error pointers.
Link: http://lkml.kernel.org/r/20170412083321.GC3250@mwanda
Fixes: 65131cd52b9e ("c2port: add c2port support for Eurotech Duramar 2150")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Rodolfo Giometti <giometti@linux.it>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/misc/c2port/c2port-duramar2150.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/misc/c2port/c2port-duramar2150.c b/drivers/misc/c2port/c2port-duramar2150.c index 5484301d57d9..3dc61ea7dc64 100644 --- a/drivers/misc/c2port/c2port-duramar2150.c +++ b/drivers/misc/c2port/c2port-duramar2150.c @@ -129,8 +129,8 @@ static int __init duramar2150_c2port_init(void) duramar2150_c2port_dev = c2port_device_register("uc", &duramar2150_c2port_ops, NULL); - if (!duramar2150_c2port_dev) { - ret = -ENODEV; + if (IS_ERR(duramar2150_c2port_dev)) { + ret = PTR_ERR(duramar2150_c2port_dev); goto free_region; } |