diff options
| author |   Al Viro <viro@ftp.linux.org.uk> | 2006-09-25 02:54:46 +0100 |
|---|---|---|
| committer |   Linus Torvalds <torvalds@g5.osdl.org> | 2006-09-24 20:07:49 -0700 |
| commit | 855fc73bf81e8f99606d6f5914c5b7c3b079d718 (patch) | |
| tree | 802cd222d609efdce191ed85369d091b86ac7771 /drivers | |
| parent | [PATCH] qla3xxx iomem annotations (diff) | |
| download | linux-dev-855fc73bf81e8f99606d6f5914c5b7c3b079d718.tar.xz linux-dev-855fc73bf81e8f99606d6f5914c5b7c3b079d718.zip | |
[PATCH] wrong thing iounmapped (qla3xxx)
ql3xxx_probe() does ioremap and stores result in ->mem_map_registers.
On failure exit it does iounmap() of the same thing.
OTOH, ql3xxx_remove() does iounmap() of ->mmap_virt_base which is
(a) never assigned and
(b) never used other than in that iounmap() call.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/net/qla3xxx.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/qla3xxx.c b/drivers/net/qla3xxx.c index c184cd80a9fc..157471846349 100644 --- a/drivers/net/qla3xxx.c +++ b/drivers/net/qla3xxx.c @@ -3508,7 +3508,7 @@ static void __devexit ql3xxx_remove(struct pci_dev *pdev) qdev->workqueue = NULL; } - iounmap(qdev->mmap_virt_base); + iounmap(qdev->mem_map_registers); pci_release_regions(pdev); pci_set_drvdata(pdev, NULL); free_netdev(ndev); |