diff options
| author |   Tejun Heo <htejun@gmail.com> | 2007-05-11 14:46:51 +0200 |
|---|---|---|
| committer |   Jeff Garzik <jeff@garzik.org> | 2007-05-11 18:09:18 -0400 |
| commit | 8575b814097af648dad284bd3087875a11b13d18 (patch) | |
| tree | 33ee44f9bafab76229df2516c309f31fd6ef428d /drivers | |
| parent | libata: fallback to the other IDENTIFY on device error, take#2 (diff) | |
| download | linux-dev-8575b814097af648dad284bd3087875a11b13d18.tar.xz linux-dev-8575b814097af648dad284bd3087875a11b13d18.zip | |
libata: give devices one last chance even if recovery failed with -EINVAL
After certain errors, some devices report complete garbage on
IDENTIFY. This can cause ata_dev_read_id() to fail with -EINVAL
resulting in immediate disabling of the device. Give the device one
last chance after -EINVAL to allow recovery from such situations. As
-EINVAL is triggered very rarely, this shouldn't cause any noticeable
affect on more common error paths.
Signed-off-by: Tejun Heo <htejun@gmail.com>
Cc: Harald Dunkel <harald.dunkel@t-online.de>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/ata/libata-eh.c | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c index ee9bb534153a..5309c312f517 100644 --- a/drivers/ata/libata-eh.c +++ b/drivers/ata/libata-eh.c @@ -2003,14 +2003,10 @@ static int ata_eh_recover(struct ata_port *ap, ata_prereset_fn_t prereset, ehc->tries[dev->devno]--; switch (rc) { - case -EINVAL: - /* eeek, something went very wrong, give up */ - ehc->tries[dev->devno] = 0; - break; - case -ENODEV: /* device missing or wrong IDENTIFY data, schedule probing */ ehc->i.probe_mask |= (1 << dev->devno); + case -EINVAL: /* give it just one more chance */ ehc->tries[dev->devno] = min(ehc->tries[dev->devno], 1); case -EIO: |