diff options
| author |   Lino Sanfilippo <LinoSanfilippo@gmx.de> | 2014-11-28 02:47:19 +0100 |
|---|---|---|
| committer |   John W. Linville <linville@tuxdriver.com> | 2014-12-01 15:57:20 -0500 |
| commit | 8e09b7d2dbb86eb3e9a714d6622f4da24e988029 (patch) | |
| tree | 1fddbc3a3ce89755a45a047bc7d06299fcb755ef /drivers | |
| parent | Merge branch 'for-linville' of git://github.com/kvalo/ath (diff) | |
| download | linux-dev-8e09b7d2dbb86eb3e9a714d6622f4da24e988029.tar.xz linux-dev-8e09b7d2dbb86eb3e9a714d6622f4da24e988029.zip | |
wil6210: Fix potential memory leaks on error paths
Fix missing memory deallocation on error paths in wil_write_file_wmi()
and wil_write_file_txmgmt().
Reported-by: Ahmed Tamrawi <ahmedtamrawi@gmail.com>
Signed-off-by: Lino Sanfilippo <LinoSanfilippo@gmx.de>
Signed-off-by: Vladimir Kondratiev <qca_vkondrat@qca.qualcomm.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/net/wireless/ath/wil6210/debugfs.c | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/drivers/net/wireless/ath/wil6210/debugfs.c b/drivers/net/wireless/ath/wil6210/debugfs.c index 54a6ddc6301b..4e6e14501c2f 100644 --- a/drivers/net/wireless/ath/wil6210/debugfs.c +++ b/drivers/net/wireless/ath/wil6210/debugfs.c @@ -573,8 +573,10 @@ static ssize_t wil_write_file_txmgmt(struct file *file, const char __user *buf, if (!frame) return -ENOMEM; - if (copy_from_user(frame, buf, len)) + if (copy_from_user(frame, buf, len)) { + kfree(frame); return -EIO; + } params.buf = frame; params.len = len; @@ -614,8 +616,10 @@ static ssize_t wil_write_file_wmi(struct file *file, const char __user *buf, return -ENOMEM; rc = simple_write_to_buffer(wmi, len, ppos, buf, len); - if (rc < 0) + if (rc < 0) { + kfree(wmi); return rc; + } cmd = &wmi[1]; cmdid = le16_to_cpu(wmi->id); |