diff options
| author |   Gustavo A. R. Silva <gustavo@embeddedor.com> | 2019-07-28 18:51:38 -0500 |
|---|---|---|
| committer |   Wolfram Sang <wsa@the-dreams.de> | 2019-08-01 22:24:16 +0200 |
| commit | 8eb9a2dff019055e4ff307bb7f8c64a7a20e79c8 (patch) | |
| tree | fca35b674a24e44e4958478be8b78e75a0d62ce5 /drivers | |
| parent | i2c: at91: fix clk_offset for sama5d2 (diff) | |
| download | linux-dev-8eb9a2dff019055e4ff307bb7f8c64a7a20e79c8.tar.xz linux-dev-8eb9a2dff019055e4ff307bb7f8c64a7a20e79c8.zip | |
i2c: s3c2410: Mark expected switch fall-through
Mark switch cases where we are expecting to fall through.
This patch fixes the following warning:
drivers/i2c/busses/i2c-s3c2410.c: In function 'i2c_s3c_irq_nextbyte':
drivers/i2c/busses/i2c-s3c2410.c:431:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
if (i2c->state == STATE_READ)
^
drivers/i2c/busses/i2c-s3c2410.c:439:2: note: here
case STATE_WRITE:
^~~~
Notice that, in this particular case, the code comment is
modified in accordance with what GCC is expecting to find.
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/i2c/busses/i2c-s3c2410.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c index d97fb857b0ea..c98ef4c4a0c9 100644 --- a/drivers/i2c/busses/i2c-s3c2410.c +++ b/drivers/i2c/busses/i2c-s3c2410.c @@ -435,6 +435,7 @@ static int i2c_s3c_irq_nextbyte(struct s3c24xx_i2c *i2c, unsigned long iicstat) * fall through to the write state, as we will need to * send a byte as well */ + /* Fall through */ case STATE_WRITE: /* |