diff options
| author |   John Sperbeck <jsperbeck@google.com> | 2022-08-01 19:22:29 +0000 |
|---|---|---|
| committer |   Joerg Roedel <jroedel@suse.de> | 2022-09-07 10:39:51 +0200 |
| commit | 94a568ce32038d8ff9257004bb4632e60eb43a49 (patch) | |
| tree | 34574ac68784b41b1ebad51fe372719da3975307 /drivers | |
| parent | Linux 6.0-rc4 (diff) | |
| download | linux-dev-94a568ce32038d8ff9257004bb4632e60eb43a49.tar.xz linux-dev-94a568ce32038d8ff9257004bb4632e60eb43a49.zip | |
iommu/amd: use full 64-bit value in build_completion_wait()
We started using a 64 bit completion value. Unfortunately, we only
stored the low 32-bits, so a very large completion value would never
be matched in iommu_completion_wait().
Fixes: c69d89aff393 ("iommu/amd: Use 4K page for completion wait write-back semaphore")
Signed-off-by: John Sperbeck <jsperbeck@google.com>
Link: https://lore.kernel.org/r/20220801192229.3358786-1-jsperbeck@google.com
Signed-off-by: Joerg Roedel <jroedel@suse.de>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/iommu/amd/iommu.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/iommu/amd/iommu.c b/drivers/iommu/amd/iommu.c index 65b8e4fd8217..828672a46a3d 100644 --- a/drivers/iommu/amd/iommu.c +++ b/drivers/iommu/amd/iommu.c @@ -939,7 +939,8 @@ static void build_completion_wait(struct iommu_cmd *cmd, memset(cmd, 0, sizeof(*cmd)); cmd->data[0] = lower_32_bits(paddr) | CMD_COMPL_WAIT_STORE_MASK; cmd->data[1] = upper_32_bits(paddr); - cmd->data[2] = data; + cmd->data[2] = lower_32_bits(data); + cmd->data[3] = upper_32_bits(data); CMD_SET_TYPE(cmd, CMD_COMPL_WAIT); } |