diff options
| author |   Jiri Pirko <jiri@mellanox.com> | 2019-10-31 11:42:21 +0200 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2019-10-31 10:54:47 -0700 |
| commit | 973b7fdb5ff17e5f19eba9103c3fcb77a01b93df (patch) | |
| tree | d68535b875ab5835504be2867569ed7b54a6c49a /drivers | |
| parent | mlxsw: spectrum: Iterate over all ports in gap during unsplit create (diff) | |
| download | linux-dev-973b7fdb5ff17e5f19eba9103c3fcb77a01b93df.tar.xz linux-dev-973b7fdb5ff17e5f19eba9103c3fcb77a01b93df.zip | |
mlxsw: spectrum: Generalize split count check
Make the check generic for any possible value, not only 2 and 4.
Signed-off-by: Jiri Pirko <jiri@mellanox.com>
Reviewed-by: Shalom Toledo <shalomt@mellanox.com>
Signed-off-by: Ido Schimmel <idosch@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum.c index 3ce48d0df37f..ea4cc2aa99e0 100644 --- a/drivers/net/ethernet/mellanox/mlxsw/spectrum.c +++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum.c @@ -4215,9 +4215,9 @@ static int mlxsw_sp_port_split(struct mlxsw_core *mlxsw_core, u8 local_port, return -EINVAL; } - if (count != 2 && count != 4) { - netdev_err(mlxsw_sp_port->dev, "Port can only be split into 2 or 4 ports\n"); - NL_SET_ERR_MSG_MOD(extack, "Port can only be split into 2 or 4 ports"); + if (count == 1 || !is_power_of_2(count) || count > max_width) { + netdev_err(mlxsw_sp_port->dev, "Invalid split count\n"); + NL_SET_ERR_MSG_MOD(extack, "Invalid split count"); return -EINVAL; } |