diff options
| author |   Dave Jiang <dave.jiang@intel.com> | 2022-04-12 11:06:32 -0700 |
|---|---|---|
| committer |   Vinod Koul <vkoul@kernel.org> | 2022-04-20 17:21:15 +0530 |
| commit | a8facc7b988599f83a680d2d61f4607cda495175 (patch) | |
| tree | de724ef3c6e63f926141d9eb4a6824b6393c7953 /drivers | |
| parent | dmaengine: mediatek: mtk-hsdma: use NULL instead of using plain integer as pointer (diff) | |
| download | linux-dev-a8facc7b988599f83a680d2d61f4607cda495175.tar.xz linux-dev-a8facc7b988599f83a680d2d61f4607cda495175.zip | |
dmaengine: add verification of DMA_INTERRUPT capability for dmatest
Looks like I forgot to add DMA_INTERRUPT cap setting to the idxd driver and
dmatest is still working regardless of this mistake. Add an explicit check
of DMA_INTERRUPT capability for dmatest to make sure the DMA device being used
actually supports interrupt before the test is launched and also that the
driver is programmed correctly.
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
Link: https://lore.kernel.org/r/164978679251.2361020.5856734256126725993.stgit@djiang5-desk3.ch.intel.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/dma/dmatest.c | 13 |
1 files changed, 10 insertions, 3 deletions
diff --git a/drivers/dma/dmatest.c b/drivers/dma/dmatest.c index f696246f57fd..0a2168a4ccb0 100644 --- a/drivers/dma/dmatest.c +++ b/drivers/dma/dmatest.c @@ -675,10 +675,16 @@ static int dmatest_func(void *data) /* * src and dst buffers are freed by ourselves below */ - if (params->polled) + if (params->polled) { flags = DMA_CTRL_ACK; - else - flags = DMA_CTRL_ACK | DMA_PREP_INTERRUPT; + } else { + if (dma_has_cap(DMA_INTERRUPT, dev->cap_mask)) { + flags = DMA_CTRL_ACK | DMA_PREP_INTERRUPT; + } else { + pr_err("Channel does not support interrupt!\n"); + goto err_pq_array; + } + } ktime = ktime_get(); while (!(kthread_should_stop() || @@ -906,6 +912,7 @@ error_unmap_continue: runtime = ktime_to_us(ktime); ret = 0; +err_pq_array: kfree(dma_pq); err_srcs_array: kfree(srcs); |