diff options
| author |   Christoph Hellwig <hch@lst.de> | 2021-07-21 10:00:11 +0200 |
|---|---|---|
| committer | Christoph Hellwig <hch@lst.de> | 2021-07-21 17:24:10 +0200 |
| commit | aaeb7bb061be545251606f4d9c82d710ca2a7c8e (patch) | |
| tree | e3e619dfd62fac8b1a7c8b6220c81af5c7067c59 /drivers | |
| parent | nvme: fix nvme_setup_command metadata trace event (diff) | |
| download | linux-dev-aaeb7bb061be545251606f4d9c82d710ca2a7c8e.tar.xz linux-dev-aaeb7bb061be545251606f4d9c82d710ca2a7c8e.zip | |
nvme: set the PRACT bit when using Write Zeroes with T10 PI
When using Write Zeroes on a namespace that has protection
information enabled they behavior without the PRACT bit
counter-intuitive and will generally lead to validation failures
when reading the written blocks. Fix this by always setting the
PRACT bit that generates matching PI data on the fly.
Fixes: 6e02318eaea5 ("nvme: add support for the Write Zeroes command")
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Keith Busch <kbusch@kernel.org>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/nvme/host/core.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c index 17c05a4595f0..dfd9dec0c1f6 100644 --- a/drivers/nvme/host/core.c +++ b/drivers/nvme/host/core.c @@ -900,7 +900,10 @@ static inline blk_status_t nvme_setup_write_zeroes(struct nvme_ns *ns, cpu_to_le64(nvme_sect_to_lba(ns, blk_rq_pos(req))); cmnd->write_zeroes.length = cpu_to_le16((blk_rq_bytes(req) >> ns->lba_shift) - 1); - cmnd->write_zeroes.control = 0; + if (nvme_ns_has_pi(ns)) + cmnd->write_zeroes.control = cpu_to_le16(NVME_RW_PRINFO_PRACT); + else + cmnd->write_zeroes.control = 0; return BLK_STS_OK; } |