diff options
| author |   Eric Dumazet <edumazet@google.com> | 2014-01-15 06:50:07 -0800 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2014-01-15 17:02:08 -0800 |
| commit | aee636c4809fa54848ff07a899b326eb1f9987a2 (patch) | |
| tree | 8f0c327f82dd7d5056dc487064f05f3f804f2fea /drivers | |
| parent | be2net: add dma_mapping_error() check for dma_map_page() (diff) | |
| download | linux-dev-aee636c4809fa54848ff07a899b326eb1f9987a2.tar.xz linux-dev-aee636c4809fa54848ff07a899b326eb1f9987a2.zip | |
bpf: do not use reciprocal divide
At first Jakub Zawadzki noticed that some divisions by reciprocal_divide
were not correct. (off by one in some cases)
http://www.wireshark.org/~darkjames/reciprocal-buggy.c
He could also show this with BPF:
http://www.wireshark.org/~darkjames/set-and-dump-filter-k-bug.c
The reciprocal divide in linux kernel is not generic enough,
lets remove its use in BPF, as it is not worth the pain with
current cpus.
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: Jakub Zawadzki <darkjames-ws@darkjames.pl>
Cc: Mircea Gherzan <mgherzan@gmail.com>
Cc: Daniel Borkmann <dxchgb@gmail.com>
Cc: Hannes Frederic Sowa <hannes@stressinduktion.org>
Cc: Matt Evans <matt@ozlabs.org>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: David S. Miller <davem@davemloft.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers')
0 files changed, 0 insertions, 0 deletions