diff options
| author |   Zhengchao Shao <shaozhengchao@huawei.com> | 2022-11-07 09:21:59 +0800 |
|---|---|---|
| committer |   Paolo Abeni <pabeni@redhat.com> | 2022-11-08 13:28:07 +0100 |
| commit | b0c09c7f08c2467b2089bdf4adb2fbbc2464f4a8 (patch) | |
| tree | 42db047f058afea3f9dd7516ef0ce0e9452adb3a /drivers | |
| parent | net: lapbether: fix issue of invalid opcode in lapbeth_open() (diff) | |
| download | linux-dev-b0c09c7f08c2467b2089bdf4adb2fbbc2464f4a8.tar.xz linux-dev-b0c09c7f08c2467b2089bdf4adb2fbbc2464f4a8.zip | |
net: ethernet: mtk-star-emac: disable napi when connect and start PHY failed in mtk_star_enable()
When failed to connect to and start PHY in mtk_star_enable() for opening
device, napi isn't disabled. When open mtk star device next time, it will
reports a invalid opcode issue. Fix it. Only be compiled, not be tested.
Fixes: 8c7bd5a454ff ("net: ethernet: mtk-star-emac: new driver")
Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
Link: https://lore.kernel.org/r/20221107012159.211387-1-shaozhengchao@huawei.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/net/ethernet/mediatek/mtk_star_emac.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/net/ethernet/mediatek/mtk_star_emac.c b/drivers/net/ethernet/mediatek/mtk_star_emac.c index 7e890f81148e..7050351250b7 100644 --- a/drivers/net/ethernet/mediatek/mtk_star_emac.c +++ b/drivers/net/ethernet/mediatek/mtk_star_emac.c @@ -1026,6 +1026,8 @@ static int mtk_star_enable(struct net_device *ndev) return 0; err_free_irq: + napi_disable(&priv->rx_napi); + napi_disable(&priv->tx_napi); free_irq(ndev->irq, ndev); err_free_skbs: mtk_star_free_rx_skbs(priv); |