diff options
| author |   Andy Shevchenko <andriy.shevchenko@linux.intel.com> | 2012-10-18 17:34:11 +0300 |
|---|---|---|
| committer |   Vinod Koul <vinod.koul@intel.com> | 2013-01-07 22:04:52 -0800 |
| commit | ba84bd7146b9244de0ce04cdc668521a73f5336f (patch) | |
| tree | ebeed6c0fa714c7efdba2e72c2f5f4a3f8ed6d21 /drivers | |
| parent | dw_dmac: don't call platform_get_drvdata twice (diff) | |
| download | linux-dev-ba84bd7146b9244de0ce04cdc668521a73f5336f.tar.xz linux-dev-ba84bd7146b9244de0ce04cdc668521a73f5336f.zip | |
dw_dmac: change dev_crit to dev_WARN in dwc_handle_error
In case of handling a bad descriptor the dwc_handle_error() will dump a stack
as well. It's a lot more verbose and more likely to get user's attention.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Reviewed-by: Felipe Balbi <balbi@ti.com>
Signed-off-by: Vinod Koul <vinod.koul@linux.intel.com>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/dma/dw_dmac.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/dma/dw_dmac.c b/drivers/dma/dw_dmac.c index d60ef9c7dd68..9a27fb70c950 100644 --- a/drivers/dma/dw_dmac.c +++ b/drivers/dma/dw_dmac.c @@ -485,14 +485,14 @@ static void dwc_handle_error(struct dw_dma *dw, struct dw_dma_chan *dwc) dwc_dostart(dwc, dwc_first_active(dwc)); /* - * KERN_CRITICAL may seem harsh, but since this only happens + * WARN may seem harsh, but since this only happens * when someone submits a bad physical address in a * descriptor, we should consider ourselves lucky that the * controller flagged an error instead of scribbling over * random memory locations. */ - dev_crit(chan2dev(&dwc->chan), "Bad descriptor submitted for DMA!\n"); - dev_crit(chan2dev(&dwc->chan), " cookie: %d\n", bad_desc->txd.cookie); + dev_WARN(chan2dev(&dwc->chan), "Bad descriptor submitted for DMA!\n" + " cookie: %d\n", bad_desc->txd.cookie); dwc_dump_lli(dwc, &bad_desc->lli); list_for_each_entry(child, &bad_desc->tx_list, desc_node) dwc_dump_lli(dwc, &child->lli); |