diff options
| author |   Coly Li <colyli@suse.de> | 2018-05-03 18:51:34 +0800 |
|---|---|---|
| committer |   Jens Axboe <axboe@kernel.dk> | 2018-05-03 08:35:12 -0600 |
| commit | bf78980fcc58bad2d61858ce342153a3dd097aa0 (patch) | |
| tree | a3a4a141df58810c02dadc33dbe848f65d451310 /drivers | |
| parent | bcache: set CACHE_SET_IO_DISABLE in bch_cached_dev_error() (diff) | |
| download | linux-dev-bf78980fcc58bad2d61858ce342153a3dd097aa0.tar.xz linux-dev-bf78980fcc58bad2d61858ce342153a3dd097aa0.zip | |
bcache: count backing device I/O error for writeback I/O
Commit c7b7bd07404c5 ("bcache: add io_disable to struct cached_dev")
counts backing device I/O requets and set dc->io_disable to true if error
counters exceeds dc->io_error_limit. But it only counts I/O errors for
regular I/O request, neglects errors of write back I/Os when backing device
is offline.
This patch counts the errors of writeback I/Os, in dirty_endio() if
bio->bi_status is not 0, it means error happens when writing dirty keys
to backing device, then bch_count_backing_io_errors() is called.
By this fix, even there is no reqular I/O request coming, if writeback I/O
errors exceed dc->io_error_limit, the bcache device may still be stopped
for the broken backing device.
Fixes: c7b7bd07404c5 ("bcache: add io_disable to struct cached_dev")
Signed-off-by: Coly Li <colyli@suse.de>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/md/bcache/writeback.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/md/bcache/writeback.c b/drivers/md/bcache/writeback.c index 4a9547cdcdc5..ad45ebe1a74b 100644 --- a/drivers/md/bcache/writeback.c +++ b/drivers/md/bcache/writeback.c @@ -244,8 +244,10 @@ static void dirty_endio(struct bio *bio) struct keybuf_key *w = bio->bi_private; struct dirty_io *io = w->private; - if (bio->bi_status) + if (bio->bi_status) { SET_KEY_DIRTY(&w->key, false); + bch_count_backing_io_errors(io->dc, bio); + } closure_put(&io->cl); } |