diff options
| author |   Wei Yongjun <weiyongjun1@huawei.com> | 2018-03-30 02:24:28 +0000 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2018-03-31 22:22:25 -0400 |
| commit | c679f6a26dc3d450b76e94717850a14ff706cc58 (patch) | |
| tree | 9af17f074957f8563e15ae40a12f33cf6b59b774 /drivers | |
| parent | netdevsim: Change nsim_devlink_setup to return error to caller (diff) | |
| download | linux-dev-c679f6a26dc3d450b76e94717850a14ff706cc58.tar.xz linux-dev-c679f6a26dc3d450b76e94717850a14ff706cc58.zip | |
net: hns3: remove unnecessary pci_set_drvdata() and devm_kfree()
There is no need for explicit calls of devm_kfree(), as the allocated
memory will be freed during driver's detach.
The driver core clears the driver data to NULL after device_release.
Thus, it is not needed to manually clear the device driver data to NULL.
So remove the unnecessary pci_set_drvdata() and devm_kfree().
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c index a31b4adf6e6a..8c55965a66ac 100644 --- a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c +++ b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c @@ -1614,10 +1614,6 @@ static void hns3_remove(struct pci_dev *pdev) struct hnae3_ae_dev *ae_dev = pci_get_drvdata(pdev); hnae3_unregister_ae_dev(ae_dev); - - devm_kfree(&pdev->dev, ae_dev); - - pci_set_drvdata(pdev, NULL); } static struct pci_driver hns3_driver = { |