diff options
| author |   Gustavo A. R. Silva <gustavo@embeddedor.com> | 2018-08-09 10:08:24 -0500 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2018-08-11 11:28:34 -0700 |
| commit | d331e7589753f02f93db350910e4bcbbecf6f726 (patch) | |
| tree | 06575bdeb925eea23678c954a73f75334e370d29 /drivers | |
| parent | rxrpc: remove redundant static int 'zero' (diff) | |
| download | linux-dev-d331e7589753f02f93db350910e4bcbbecf6f726.tar.xz linux-dev-d331e7589753f02f93db350910e4bcbbecf6f726.zip | |
net: dp83640: Mark expected switch fall-throughs
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Notice that in this particular case, I replaced the code comment at the
top of the switch statement with a proper "fall through" annotation for
each case, which is what GCC is expecting to find.
Addresses-Coverity-ID: 1056542 ("Missing break in switch")
Addresses-Coverity-ID: 1339579 ("Missing break in switch")
Addresses-Coverity-ID: 1369526 ("Missing break in switch")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Acked-by: Richard Cochran <richardcochran@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/net/phy/dp83640.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/net/phy/dp83640.c b/drivers/net/phy/dp83640.c index 79e9b103188b..29aa8d772b0c 100644 --- a/drivers/net/phy/dp83640.c +++ b/drivers/net/phy/dp83640.c @@ -757,13 +757,16 @@ static int decode_evnt(struct dp83640_private *dp83640, phy_txts = data; - switch (words) { /* fall through in every case */ + switch (words) { case 3: dp83640->edata.sec_hi = phy_txts->sec_hi; + /* fall through */ case 2: dp83640->edata.sec_lo = phy_txts->sec_lo; + /* fall through */ case 1: dp83640->edata.ns_hi = phy_txts->ns_hi; + /* fall through */ case 0: dp83640->edata.ns_lo = phy_txts->ns_lo; } |