diff options
| author |   Eric Dumazet <edumazet@google.com> | 2017-04-19 09:59:23 -0700 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2017-04-21 13:24:05 -0400 |
| commit | d532c1082f68176363ed766d09bf187616e282fe (patch) | |
| tree | dafe565d6dad6ad3735fd3573519911d2b996716 /drivers | |
| parent | cx82310_eth: use skb_cow_head() to deal with cloned skbs (diff) | |
| download | linux-dev-d532c1082f68176363ed766d09bf187616e282fe.tar.xz linux-dev-d532c1082f68176363ed766d09bf187616e282fe.zip | |
sr9700: use skb_cow_head() to deal with cloned skbs
We need to ensure there is enough headroom to push extra header,
but we also need to check if we are allowed to change headers.
skb_cow_head() is the proper helper to deal with this.
Fixes: c9b37458e956 ("USB2NET : SR9700 : One chip USB 1.1 USB2NET SR9700Device Driver Support")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: James Hughes <james.hughes@raspberrypi.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/net/usb/sr9700.c | 9 |
1 files changed, 2 insertions, 7 deletions
diff --git a/drivers/net/usb/sr9700.c b/drivers/net/usb/sr9700.c index 4a1e9c489f1f..aadfe1d1c37e 100644 --- a/drivers/net/usb/sr9700.c +++ b/drivers/net/usb/sr9700.c @@ -456,14 +456,9 @@ static struct sk_buff *sr9700_tx_fixup(struct usbnet *dev, struct sk_buff *skb, len = skb->len; - if (skb_headroom(skb) < SR_TX_OVERHEAD) { - struct sk_buff *skb2; - - skb2 = skb_copy_expand(skb, SR_TX_OVERHEAD, 0, flags); + if (skb_cow_head(skb, SR_TX_OVERHEAD)) { dev_kfree_skb_any(skb); - skb = skb2; - if (!skb) - return NULL; + return NULL; } __skb_push(skb, SR_TX_OVERHEAD); |