diff options
| author |   Zhu Lingshan <lingshan.zhu@intel.com> | 2020-10-23 18:40:46 +0800 |
|---|---|---|
| committer |   Michael S. Tsirkin <mst@redhat.com> | 2020-10-30 04:02:53 -0400 |
| commit | e01afe36df1a9e42cacdb9c5b99512ec69a6f14b (patch) | |
| tree | c4b8e9e2239abc8577a827d0660652848784a6cf /drivers | |
| parent | vdpa_sim: Fix DMA mask (diff) | |
| download | linux-dev-e01afe36df1a9e42cacdb9c5b99512ec69a6f14b.tar.xz linux-dev-e01afe36df1a9e42cacdb9c5b99512ec69a6f14b.zip | |
vdpa: handle irq bypass register failure case
LKP considered variable 'ret' in vhost_vdpa_setup_vq_irq() as
a unused variable, so suggest we remove it. Actually it stores
return value of irq_bypass_register_producer(), but we did not
check it, we should handle the failure case.
This commit will print a message if irq bypass register producer
fail, in this case, vqs still remain functional.
Signed-off-by: Zhu Lingshan <lingshan.zhu@intel.com>
Reported-by: kernel test robot <lkp@intel.com>
Link: https://lore.kernel.org/r/20201023104046.404794-1-lingshan.zhu@intel.com
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Acked-by: Jason Wang <jasowang@redhat.com>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/vhost/vdpa.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c index ec223da70a73..2754f3069738 100644 --- a/drivers/vhost/vdpa.c +++ b/drivers/vhost/vdpa.c @@ -104,6 +104,9 @@ static void vhost_vdpa_setup_vq_irq(struct vhost_vdpa *v, u16 qid) vq->call_ctx.producer.token = vq->call_ctx.ctx; vq->call_ctx.producer.irq = irq; ret = irq_bypass_register_producer(&vq->call_ctx.producer); + if (unlikely(ret)) + dev_info(&v->dev, "vq %u, irq bypass producer (token %p) registration fails, ret = %d\n", + qid, vq->call_ctx.producer.token, ret); } static void vhost_vdpa_unsetup_vq_irq(struct vhost_vdpa *v, u16 qid) |