diff options
| author |   Nick Stoughton <nstoughton@logitech.com> | 2019-07-17 14:56:06 -0700 |
|---|---|---|
| committer |   Jacek Anaszewski <jacek.anaszewski@gmail.com> | 2019-07-22 20:35:01 +0200 |
| commit | ed2abfebb041473092b41527903f93390d38afa7 (patch) | |
| tree | 803ab63814af8fef67995d9f6db33021bc8b905d /drivers | |
| parent | leds: ns2: Add of_node_put() before return (diff) | |
| download | linux-dev-ed2abfebb041473092b41527903f93390d38afa7.tar.xz linux-dev-ed2abfebb041473092b41527903f93390d38afa7.zip | |
leds: leds-lp5562 allow firmware files up to the maximum length
Firmware files are in ASCII, using 2 hex characters per byte. The
maximum length of a firmware string is therefore
16 (commands) * 2 (bytes per command) * 2 (characters per byte) = 64
Fixes: ff45262a85db ("leds: add new LP5562 LED driver")
Signed-off-by: Nick Stoughton <nstoughton@logitech.com>
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/leds/leds-lp5562.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/drivers/leds/leds-lp5562.c b/drivers/leds/leds-lp5562.c index 37632fc63741..edb57c42e8b1 100644 --- a/drivers/leds/leds-lp5562.c +++ b/drivers/leds/leds-lp5562.c @@ -260,7 +260,11 @@ static void lp5562_firmware_loaded(struct lp55xx_chip *chip) { const struct firmware *fw = chip->fw; - if (fw->size > LP5562_PROGRAM_LENGTH) { + /* + * the firmware is encoded in ascii hex character, with 2 chars + * per byte + */ + if (fw->size > (LP5562_PROGRAM_LENGTH * 2)) { dev_err(&chip->cl->dev, "firmware data size overflow: %zu\n", fw->size); return; |