diff options
| author |   AnilKumar Ch <anilkumar@ti.com> | 2012-05-23 17:45:11 +0530 |
|---|---|---|
| committer |   Marc Kleine-Budde <mkl@pengutronix.de> | 2012-06-03 18:59:20 +0200 |
| commit | f461f27a4436dbe691908fe08b867ef888848cc3 (patch) | |
| tree | 2d1d433868d33b6ec59e3685245adc197384f365 /drivers | |
| parent | can: c_can: fix an interrupt thrash issue with c_can driver (diff) | |
| download | linux-dev-f461f27a4436dbe691908fe08b867ef888848cc3.tar.xz linux-dev-f461f27a4436dbe691908fe08b867ef888848cc3.zip | |
can: c_can: fix race condition in c_can_open()
Fix the issue of C_CAN interrupts getting disabled forever when canconfig
utility is used multiple times. According to NAPI usage we disable all
the hardware interrupts in ISR and re-enable them in poll(). Current
implementation calls napi_enable() after hardware interrupts are enabled.
If we get any interrupts between these two steps then we do not process
those interrupts because napi is not enabled. Mostly these interrupts
come because of STATUS is not 0x7 or ERROR interrupts. If napi_enable()
happens before HW interrupts enabled then c_can_poll() function will be
called eventual re-enabling.
This patch moves the napi_enable() call before interrupts enabled.
Cc: stable@kernel.org # 2.6.39+
Signed-off-by: AnilKumar Ch <anilkumar@ti.com>
Acked-by: Wolfgang Grandegger <wg@grandegger.com>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/net/can/c_can/c_can.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/net/can/c_can/c_can.c b/drivers/net/can/c_can/c_can.c index fa016214c52f..8dc84d66eea1 100644 --- a/drivers/net/can/c_can/c_can.c +++ b/drivers/net/can/c_can/c_can.c @@ -1064,10 +1064,11 @@ static int c_can_open(struct net_device *dev) goto exit_irq_fail; } + napi_enable(&priv->napi); + /* start the c_can controller */ c_can_start(dev); - napi_enable(&priv->napi); netif_start_queue(dev); return 0; |