diff options
| author |   Ido Schimmel <idosch@nvidia.com> | 2020-11-17 19:46:56 +0200 |
|---|---|---|
| committer |   Jakub Kicinski <kuba@kernel.org> | 2020-11-18 11:51:18 -0800 |
| commit | fbf805bf1fcd125461541a171194f9dcdb2732d7 (patch) | |
| tree | 7c218e7a65b0a0b20127c06b827690ec571107da /drivers | |
| parent | ptp: document struct ptp_clock_request members (diff) | |
| download | linux-dev-fbf805bf1fcd125461541a171194f9dcdb2732d7.tar.xz linux-dev-fbf805bf1fcd125461541a171194f9dcdb2732d7.zip | |
mlxsw: spectrum_router: Fix wrong kfree() in error path
The function allocates 'nhgi', not 'nh_grp', so it needs to free the
former in its error path.
Fixes: 7f7a417e6a11 ("mlxsw: spectrum_router: Split nexthop group configuration to a different struct")
Addresses-Coverity: ("Memory - corruptions (USE_AFTER_FREE)")
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
Signed-off-by: Ido Schimmel <idosch@nvidia.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c index a2e81ad5790f..7dbf02f45913 100644 --- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c +++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c @@ -5423,7 +5423,7 @@ err_nexthop6_init: nh = &nhgi->nexthops[i]; mlxsw_sp_nexthop6_fini(mlxsw_sp, nh); } - kfree(nh_grp); + kfree(nhgi); return err; } |