diff options
| author |   Dan Carpenter <dan.carpenter@oracle.com> | 2020-12-01 10:04:34 +0300 |
|---|---|---|
| committer |   Dominique Martinet <asmadeus@codewreck.org> | 2020-12-01 08:19:02 +0100 |
| commit | cfd1d0f524a87b7d6d14b41a14fa4cbe522cf8cc (patch) | |
| tree | 8049ba04943044862d1f1a65b5e45147decbc355 /fs/9p/fid.c | |
| parent | 9p: Uninitialized variable in v9fs_writeback_fid() (diff) | |
| download | linux-dev-cfd1d0f524a87b7d6d14b41a14fa4cbe522cf8cc.tar.xz linux-dev-cfd1d0f524a87b7d6d14b41a14fa4cbe522cf8cc.zip | |
9p: Remove unnecessary IS_ERR() check
The "fid" variable can't be an error pointer so there is no need to
check. The code is slightly cleaner if we move the increment before
the break and remove the NULL check as well.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Dominique Martinet <asmadeus@codewreck.org>
Diffstat (limited to 'fs/9p/fid.c')
| -rw-r--r-- | fs/9p/fid.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/fs/9p/fid.c b/fs/9p/fid.c index 79837f1b1c91..9d9de62592be 100644 --- a/fs/9p/fid.c +++ b/fs/9p/fid.c @@ -56,12 +56,11 @@ static struct p9_fid *v9fs_fid_find_inode(struct inode *inode, kuid_t uid) h = (struct hlist_head *)&inode->i_private; hlist_for_each_entry(fid, h, ilist) { if (uid_eq(fid->uid, uid)) { + refcount_inc(&fid->count); ret = fid; break; } } - if (ret && !IS_ERR(ret)) - refcount_inc(&ret->count); spin_unlock(&inode->i_lock); return ret; } |