diff options
| author |   Pan Bian <bianpan2016@163.com> | 2021-01-20 00:51:13 -0800 |
|---|---|---|
| committer |   David Sterba <dsterba@suse.com> | 2021-02-09 17:11:03 +0100 |
| commit | 70779b897395b330ba5a47bed84f94178da599f9 (patch) | |
| tree | dab88538affbb32feea48a17ae911ba1e78ead98 /fs/affs | |
| parent | Linux 5.11-rc7 (diff) | |
| download | linux-dev-70779b897395b330ba5a47bed84f94178da599f9.tar.xz linux-dev-70779b897395b330ba5a47bed84f94178da599f9.zip | |
fs/affs: release old buffer head on error path
The reference count of the old buffer head should be decremented on path
that fails to get the new buffer head.
Fixes: 6b4657667ba0 ("fs/affs: add rename exchange")
CC: stable@vger.kernel.org # 4.14+
Signed-off-by: Pan Bian <bianpan2016@163.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'fs/affs')
| -rw-r--r-- | fs/affs/namei.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/fs/affs/namei.c b/fs/affs/namei.c index 41c5749f4db7..5400a876d73f 100644 --- a/fs/affs/namei.c +++ b/fs/affs/namei.c @@ -460,8 +460,10 @@ affs_xrename(struct inode *old_dir, struct dentry *old_dentry, return -EIO; bh_new = affs_bread(sb, d_inode(new_dentry)->i_ino); - if (!bh_new) + if (!bh_new) { + affs_brelse(bh_old); return -EIO; + } /* Remove old header from its parent directory. */ affs_lock_dir(old_dir); |