diff options
| author |   Al Viro <viro@zeniv.linux.org.uk> | 2019-10-25 00:03:11 -0400 |
|---|---|---|
| committer | Al Viro <viro@zeniv.linux.org.uk> | 2019-10-25 00:03:11 -0400 |
| commit | 03ad0d703df75c43f78bd72e16124b5b94a95188 (patch) | |
| tree | d3915a4d9c614df558bbdd073544786e09595b5e /fs/autofs | |
| parent | aio: Fix io_pgetevents() struct __compat_aio_sigset layout (diff) | |
| download | linux-dev-03ad0d703df75c43f78bd72e16124b5b94a95188.tar.xz linux-dev-03ad0d703df75c43f78bd72e16124b5b94a95188.zip | |
autofs: fix a leak in autofs_expire_indirect()
if the second call of should_expire() in there ends up
grabbing and returning a new reference to dentry, we need
to drop it before continuing.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs/autofs')
| -rw-r--r-- | fs/autofs/expire.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/fs/autofs/expire.c b/fs/autofs/expire.c index 2866fabf497f..91f5787dae7c 100644 --- a/fs/autofs/expire.c +++ b/fs/autofs/expire.c @@ -459,9 +459,10 @@ static struct dentry *autofs_expire_indirect(struct super_block *sb, */ how &= ~AUTOFS_EXP_LEAVES; found = should_expire(expired, mnt, timeout, how); - if (!found || found != expired) - /* Something has changed, continue */ + if (found != expired) { // something has changed, continue + dput(found); goto next; + } if (expired != dentry) dput(dentry); |