diff options
| author |   Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> | 2011-02-07 13:36:16 +0000 |
|---|---|---|
| committer |   Linus Torvalds <torvalds@linux-foundation.org> | 2011-02-07 14:04:00 -0800 |
| commit | fb2b2a1d37f80cc818fd4487b510f4e11816e5e1 (patch) | |
| tree | 00a16a9440fb1d522160a404c97ed327f77a92a1 /fs/btrfs/acl.c | |
| parent | CRED: Fix BUG() upon security_cred_alloc_blank() failure (diff) | |
| download | linux-dev-fb2b2a1d37f80cc818fd4487b510f4e11816e5e1.tar.xz linux-dev-fb2b2a1d37f80cc818fd4487b510f4e11816e5e1.zip | |
CRED: Fix memory and refcount leaks upon security_prepare_creds() failure
In prepare_kernel_cred() since 2.6.29, put_cred(new) is called without
assigning new->usage when security_prepare_creds() returned an error. As a
result, memory for new and refcount for new->{user,group_info,tgcred} are
leaked because put_cred(new) won't call __put_cred() unless old->usage == 1.
Fix these leaks by assigning new->usage (and new->subscribers which was added
in 2.6.32) before calling security_prepare_creds().
Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Signed-off-by: David Howells <dhowells@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs/btrfs/acl.c')
0 files changed, 0 insertions, 0 deletions