diff options
| author |   Josef Bacik <josef@toxicpanda.com> | 2019-04-10 15:56:09 -0400 |
|---|---|---|
| committer |   David Sterba <dsterba@suse.com> | 2019-04-29 19:25:37 +0200 |
| commit | 4297ff84dc24d120753e0425702e8ad9b80ed10f (patch) | |
| tree | 1067cbeed0ca1e28f56402343a6b156c6ac91bea /fs/btrfs/ctree.h | |
| parent | btrfs: merge calls of btrfs_setxattr and btrfs_setxattr_trans in btrfs_set_prop (diff) | |
| download | linux-dev-4297ff84dc24d120753e0425702e8ad9b80ed10f.tar.xz linux-dev-4297ff84dc24d120753e0425702e8ad9b80ed10f.zip | |
btrfs: track DIO bytes in flight
When diagnosing a slowdown of generic/224 I noticed we were not doing
anything when calling into shrink_delalloc(). This is because all
writes in 224 are O_DIRECT, not delalloc, and thus our delalloc_bytes
counter is 0, which short circuits most of the work inside of
shrink_delalloc(). However O_DIRECT writes still consume metadata
resources and generate ordered extents, which we can still wait on.
Fix this by tracking outstanding DIO write bytes, and use this as well
as the delalloc bytes counter to decide if we need to lookup and wait on
any ordered extents. If we have more DIO writes than delalloc bytes
we'll go ahead and wait on any ordered extents regardless of our flush
state as flushing delalloc is likely to not gain us anything.
Signed-off-by: Josef Bacik <josef@toxicpanda.com>
[ use dio instead of odirect in identifiers ]
Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'fs/btrfs/ctree.h')
| -rw-r--r-- | fs/btrfs/ctree.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/fs/btrfs/ctree.h b/fs/btrfs/ctree.h index aeaadeebc1fd..b81c331b28fa 100644 --- a/fs/btrfs/ctree.h +++ b/fs/btrfs/ctree.h @@ -1016,6 +1016,7 @@ struct btrfs_fs_info { /* used to keep from writing metadata until there is a nice batch */ struct percpu_counter dirty_metadata_bytes; struct percpu_counter delalloc_bytes; + struct percpu_counter dio_bytes; s32 dirty_metadata_batch; s32 delalloc_batch; |