diff options
| author |   Qu Wenruo <quwenruo@cn.fujitsu.com> | 2015-10-26 14:11:18 +0800 |
|---|---|---|
| committer |   Chris Mason <clm@fb.com> | 2015-10-26 19:44:39 -0700 |
| commit | 5846a3c26873e86b034c702a8bc202aa76082369 (patch) | |
| tree | 8495bf1ae8236d363579751a63414ba31c498a0d /fs/btrfs/ctree.h | |
| parent | btrfs: clear PF_NOFREEZE in cleaner_kthread() (diff) | |
| download | linux-dev-5846a3c26873e86b034c702a8bc202aa76082369.tar.xz linux-dev-5846a3c26873e86b034c702a8bc202aa76082369.zip | |
btrfs: qgroup: Fix a race in delayed_ref which leads to abort trans
Between btrfs_allocerved_file_extent() and
btrfs_add_delayed_qgroup_reserve(), there is a window that delayed_refs
are run and delayed ref head maybe freed before
btrfs_add_delayed_qgroup_reserve().
This will cause btrfs_dad_delayed_qgroup_reserve() to return -ENOENT,
and cause transaction to be aborted.
This patch will record qgroup reserve space info into delayed_ref_head
at btrfs_add_delayed_ref(), to eliminate the race window.
Reported-by: Filipe Manana <fdmanana@suse.com>
Signed-off-by: Qu Wenruo <quwenruo@cn.fujitsu.com>
Signed-off-by: Chris Mason <clm@fb.com>
Diffstat (limited to 'fs/btrfs/ctree.h')
| -rw-r--r-- | fs/btrfs/ctree.h | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/fs/btrfs/ctree.h b/fs/btrfs/ctree.h index 4001585ec434..a2e73f6053a8 100644 --- a/fs/btrfs/ctree.h +++ b/fs/btrfs/ctree.h @@ -3430,7 +3430,8 @@ void btrfs_free_tree_block(struct btrfs_trans_handle *trans, int btrfs_alloc_reserved_file_extent(struct btrfs_trans_handle *trans, struct btrfs_root *root, u64 root_objectid, u64 owner, - u64 offset, struct btrfs_key *ins); + u64 offset, u64 ram_bytes, + struct btrfs_key *ins); int btrfs_alloc_logged_file_extent(struct btrfs_trans_handle *trans, struct btrfs_root *root, u64 root_objectid, u64 owner, u64 offset, |