diff options
| author |   Nikolay Borisov <nborisov@suse.com> | 2019-05-14 13:54:45 +0300 |
|---|---|---|
| committer |   David Sterba <dsterba@suse.com> | 2019-07-01 13:34:55 +0200 |
| commit | 2ed95d2d59b065f4db2fd42752cbe9a00969f2bd (patch) | |
| tree | cd826f97a53c33f54e8d24bb189de99a08839c21 /fs/btrfs/dev-replace.c | |
| parent | btrfs: Explicitly reserve space for devreplace item (diff) | |
| download | linux-dev-2ed95d2d59b065f4db2fd42752cbe9a00969f2bd.tar.xz linux-dev-2ed95d2d59b065f4db2fd42752cbe9a00969f2bd.zip | |
btrfs: Remove redundant assignment of tgt_device->commit_total_bytes
This is already done in btrfs_init_dev_replace_tgtdev which is the first
phase of device replace, called before doing scrub. During that time
exclusive lock is held. Additionally btrfs_fs_device::commit_total_bytes
is always set based on the size of the underlying block device which
shouldn't change once set. This makes the 2nd assignment of the variable
in the finishing phase redundant.
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
Signed-off-by: Nikolay Borisov <nborisov@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'fs/btrfs/dev-replace.c')
| -rw-r--r-- | fs/btrfs/dev-replace.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/fs/btrfs/dev-replace.c b/fs/btrfs/dev-replace.c index 45c5ba7d80ed..b0ba5839ec08 100644 --- a/fs/btrfs/dev-replace.c +++ b/fs/btrfs/dev-replace.c @@ -674,7 +674,6 @@ static int btrfs_dev_replace_finishing(struct btrfs_fs_info *fs_info, btrfs_device_set_disk_total_bytes(tgt_device, src_device->disk_total_bytes); btrfs_device_set_bytes_used(tgt_device, src_device->bytes_used); - tgt_device->commit_total_bytes = src_device->commit_total_bytes; tgt_device->commit_bytes_used = src_device->bytes_used; btrfs_assign_next_active_device(src_device, tgt_device); |