diff options
| author |   Dan Carpenter <dan.carpenter@oracle.com> | 2019-02-11 21:32:10 +0300 |
|---|---|---|
| committer |   David Sterba <dsterba@suse.com> | 2019-02-25 14:13:41 +0100 |
| commit | 669e859b5ea7c6f4fce0149d3907c64e550c294b (patch) | |
| tree | 924066e3cd8358f345bebb385d037ff178cdd423 /fs/btrfs/dev-replace.c | |
| parent | btrfs: ensure that a DUP or RAID1 block group has exactly two stripes (diff) | |
| download | linux-dev-669e859b5ea7c6f4fce0149d3907c64e550c294b.tar.xz linux-dev-669e859b5ea7c6f4fce0149d3907c64e550c294b.zip | |
btrfs: drop the lock on error in btrfs_dev_replace_cancel
We should drop the lock on this error path. This has been found by a
static tool.
The lock needs to be released, it's there to protect access to the
dev_replace members and is not supposed to be left locked. The value of
state that's being switched would need to be artifically changed to an
invalid value so the default: branch is taken.
Fixes: d189dd70e255 ("btrfs: fix use-after-free due to race between replace start and cancel")
CC: stable@vger.kernel.org # 5.0+
Reviewed-by: Anand Jain <anand.jain@oracle.com>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'fs/btrfs/dev-replace.c')
| -rw-r--r-- | fs/btrfs/dev-replace.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/fs/btrfs/dev-replace.c b/fs/btrfs/dev-replace.c index 13863354ff9d..ee193c5222b2 100644 --- a/fs/btrfs/dev-replace.c +++ b/fs/btrfs/dev-replace.c @@ -862,6 +862,7 @@ int btrfs_dev_replace_cancel(struct btrfs_fs_info *fs_info) btrfs_destroy_dev_replace_tgtdev(tgt_device); break; default: + up_write(&dev_replace->rwsem); result = -EINVAL; } |