diff options
author | 2019-05-23 14:51:26 +0300 | |
---|---|---|
committer | 2019-09-09 14:59:02 +0200 | |
commit | e678934cbe5f026c2765a1da651e61daa5724fb3 (patch) | |
tree | e1070146d58367624b9ec65eb0ced82515958de5 /fs/btrfs/ioctl.c | |
parent | Btrfs: wake up inode cache waiters sooner to reduce waiting time (diff) | |
download | linux-dev-e678934cbe5f026c2765a1da651e61daa5724fb3.tar.xz linux-dev-e678934cbe5f026c2765a1da651e61daa5724fb3.zip |
btrfs: Remove unnecessary check from join_running_log_trans
join_running_log_trans checks btrfs_root::log_root outside of
btrfs_root::log_mutex to avoid contention on the mutex. Turns out this
check is not necessary because the two callers of join_running_log_trans
(both of which deal with removing entries from the tree-log during
unlink) explicitly check whether the respective inode has been logged in
the current transaction.
If it hasn't then it won't have any items in the tree-log and call path
will return before calling join_running_log_trans. If the check passes,
however, then it's guaranteed that btrfs_root::log_root is set because
the inode is logged.
Those guarantees allows us to remove the speculative as well as the
implicity and tricky memory barrier.
Reviewed-by: Filipe Manana <fdmanana@suse.com>
Signed-off-by: Nikolay Borisov <nborisov@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'fs/btrfs/ioctl.c')
0 files changed, 0 insertions, 0 deletions