diff options
| author |   Naohiro Aota <naohiro.aota@wdc.com> | 2022-07-09 08:18:46 +0900 |
|---|---|---|
| committer |   David Sterba <dsterba@suse.com> | 2022-07-25 17:45:42 +0200 |
| commit | 79417d040f4f77b19c701bccc23013b9cdac358d (patch) | |
| tree | f2ce47792e73a7492adb24f7ed71275bb1518c42 /fs/btrfs/space-info.c | |
| parent | btrfs: zoned: introduce space_info->active_total_bytes (diff) | |
| download | linux-dev-79417d040f4f77b19c701bccc23013b9cdac358d.tar.xz linux-dev-79417d040f4f77b19c701bccc23013b9cdac358d.zip | |
btrfs: zoned: disable metadata overcommit for zoned
The metadata overcommit makes the space reservation flexible but it is also
harmful to active zone tracking. Since we cannot finish a block group from
the metadata allocation context, we might not activate a new block group
and might not be able to actually write out the overcommit reservations.
So, disable metadata overcommit for zoned filesystems. We will ensure
the reservations are under active_total_bytes in the following patches.
CC: stable@vger.kernel.org # 5.16+
Fixes: afba2bc036b0 ("btrfs: zoned: implement active zone tracking")
Signed-off-by: Naohiro Aota <naohiro.aota@wdc.com>
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'fs/btrfs/space-info.c')
| -rw-r--r-- | fs/btrfs/space-info.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/fs/btrfs/space-info.c b/fs/btrfs/space-info.c index 826193c31dff..5284312aad04 100644 --- a/fs/btrfs/space-info.c +++ b/fs/btrfs/space-info.c @@ -399,7 +399,10 @@ int btrfs_can_overcommit(struct btrfs_fs_info *fs_info, return 0; used = btrfs_space_info_used(space_info, true); - avail = calc_available_free_space(fs_info, space_info, flush); + if (btrfs_is_zoned(fs_info) && (space_info->flags & BTRFS_BLOCK_GROUP_METADATA)) + avail = 0; + else + avail = calc_available_free_space(fs_info, space_info, flush); if (used + bytes < writable_total_bytes(fs_info, space_info) + avail) return 1; |