diff options
| author |   Aleksa Sarai <asarai@suse.de> | 2017-07-04 21:49:06 +1000 |
|---|---|---|
| committer |   David Sterba <dsterba@suse.com> | 2017-08-16 16:12:01 +0200 |
| commit | 6c6b5a39c4bf3dbd8cf629c9f5450e983c19dbb9 (patch) | |
| tree | 7c2a42b4c3ec9ccb33004b10bd85efd11e45a4e2 /fs/btrfs/super.c | |
| parent | btrfs: clean up extraneous computations in add_delayed_refs (diff) | |
| download | linux-dev-6c6b5a39c4bf3dbd8cf629c9f5450e983c19dbb9.tar.xz linux-dev-6c6b5a39c4bf3dbd8cf629c9f5450e983c19dbb9.zip | |
btrfs: resume qgroup rescan on rw remount
Several distributions mount the "proper root" as ro during initrd and
then remount it as rw before pivot_root(2). Thus, if a rescan had been
aborted by a previous shutdown, the rescan would never be resumed.
This issue would manifest itself as several btrfs ioctl(2)s causing the
entire machine to hang when btrfs_qgroup_wait_for_completion was hit
(due to the fs_info->qgroup_rescan_running flag being set but the rescan
itself not being resumed). Notably, Docker's btrfs storage driver makes
regular use of BTRFS_QUOTA_CTL_DISABLE and BTRFS_IOC_QUOTA_RESCAN_WAIT
(causing this problem to be manifested on boot for some machines).
Cc: <stable@vger.kernel.org> # v3.11+
Cc: Jeff Mahoney <jeffm@suse.com>
Fixes: b382a324b60f ("Btrfs: fix qgroup rescan resume on mount")
Signed-off-by: Aleksa Sarai <asarai@suse.de>
Reviewed-by: Nikolay Borisov <nborisov@suse.com>
Tested-by: Nikolay Borisov <nborisov@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'fs/btrfs/super.c')
| -rw-r--r-- | fs/btrfs/super.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/fs/btrfs/super.c b/fs/btrfs/super.c index 58650f2e0f17..2351794fbc44 100644 --- a/fs/btrfs/super.c +++ b/fs/btrfs/super.c @@ -1815,6 +1815,8 @@ static int btrfs_remount(struct super_block *sb, int *flags, char *data) goto restore; } + btrfs_qgroup_rescan_resume(fs_info); + if (!fs_info->uuid_root) { btrfs_info(fs_info, "creating UUID tree"); ret = btrfs_create_uuid_tree(fs_info); |